Fix displaying MIES data from 2015 #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't search for NaN here but need to search for an empty string. This was not caught by the test as that used an empty wave and for these FindValue does not complain. The fallout from this bug is an empty row range in the labnotebook. Which should not matter.
…ack path We only have 9 layers since 5624398 (Introduce a nineth layer in the labnotebooks for storing headstage independent data, 2015-10-28) so we need to index statusHS only for the first 8 layers.
t-b
deleted the
bugfix/2334-very-old-data-createtiled-channel-graph-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #2333.
Will merge once CI passes.